Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we keep the same binary name and same location of devel files ? #713

Closed
sergiomb2 opened this issue May 24, 2021 · 8 comments
Closed

Comments

@sergiomb2
Copy link
Contributor

sergiomb2 commented May 24, 2021

in https://src.fedoraproject.org/rpms/mlt/pull-request/3 I was doing a binary and devel compatibility of mlt-7 with mlt-6 , I don't think we ever need maintain both versions, AFAIK the big change is cmake ( the way we compile it ) .
So instead I do the compatibility downstream , can we done upstream and for all ?

Thank you

@sergiomb2
Copy link
Contributor Author

sergiomb2 commented May 24, 2021

@sergiomb2
Copy link
Contributor Author

why cmake: add major version to files/dirs [1] ? this breaks builds of all packages (kdenlive, synfig , shotcut)

[1]
d56f8e4

@sergiomb2
Copy link
Contributor Author

with [1] I can build synfig , but kdenlive searches for mlt.so not for mlt-7.so , so I prefer rollback "add major version to files/dirs" , also openshot which use python should not work since mlt.py also changed to mlt-7.py etc .

[1]

ln -sr %{buildroot}%{_libdir}/pkgconfig/mlt-framework-7.pc %{buildroot}%{_libdir}/pkgconfig/mlt-framework.pc
ln -sr %{buildroot}%{_libdir}/pkgconfig/mlt++-7.pc %{buildroot}%{_libdir}/pkgconfig/mlt++.pc
ln -sr %{buildroot}%{_includedir}/mlt-7 %{buildroot}%{_includedir}/mlt
ln -sr %{buildroot}%{_includedir}/mlt-7/mlt++ %{buildroot}%{_includedir}/mlt++

@ddennedy
Copy link
Member

It is intentional to break compatibility of the build until the app has migrate to this major new version. The whole idea of a major new version is API breakage. Lots of projects put their major version into things now to facilitate multiple major versions installed at the same time. Only Shotcut is currently compatible with MLT 7.

@ddennedy
Copy link
Member

@vpinon
Copy link
Contributor

vpinon commented May 28, 2021

Kdenlive has a work/mlt7 branch, that will land in 21.08 release.
Its embedded FindMLT.cmake got adapted and works (even if not perfect), ideally it could be shipped by MLT (it was on eszlari todo list, but has not happened yet).

@sergiomb2
Copy link
Contributor Author

It is intentional to break compatibility of the build until the app has migrate to this major new version. The whole idea of a major new version is API breakage. Lots of projects put their major version into things now to facilitate multiple major versions installed at the same time. Only Shotcut is currently compatible with MLT 7.

when you change /usr/lib64/libmlt.so.6 to /usr/lib64/libmlt.so.7 , soname bump . We can deduce that we have an api breakage , it is enough , you don't need add major versions in all places , I think that how it works

@sergiomb2
Copy link
Contributor Author

Lots of projects put their major version into things now to facilitate multiple major versions installed at the same time

That is the point, I don't want pack multiple versions of MLT ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants