Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/x na mask in forward mask #77

Merged
merged 4 commits into from Jan 16, 2022
Merged

Bugfix/x na mask in forward mask #77

merged 4 commits into from Jan 16, 2022

Conversation

cregouby
Copy link
Collaborator

fix #75 and move x_na_mask management to resolve_data() for consistency and lisibility

@cregouby cregouby requested a review from dfalbel January 15, 2022 22:51
dfalbel
dfalbel approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@dfalbel dfalbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cregouby cregouby merged commit 584df4b into main Jan 16, 2022
@cregouby
Copy link
Collaborator Author

Thanks a lot !

@cregouby cregouby deleted the bugfix/x_na_mask_in_forward_mask branch January 16, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfalbel dfalbel dfalbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nn_modules $forward_masks() do not take into account x_na_mask
2 participants
@cregouby @dfalbel