Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues involving loading configuration via Json #25

Closed
ExcaliburVT opened this issue Mar 6, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@ExcaliburVT
Copy link
Contributor

commented Mar 6, 2019

[Folder]:new() doesn't have a 3 parameter overload, assume it was refactored and not tested with the JSON Version

Two calls to the += operator were not valid and did not appear to be needed.

Converted the true/false to boolean just like the GetXmlFolderItems method.

Added a Json version of the example ReportConfiguration file

@mmajcica

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2019

First of all, thanks.
You are right assuming that the JSON config was not much tested. Initially, the configuration should have only be supplied via the JSON config file, however, during the development on the customers site I realized that XML is going to be the format, so I decided to implement the necessary and I tested thoroughly only XML config files.
I did a quick review of the changes you made, if you do agree with my comments, I'll merge and deploy a new version today.

@ExcaliburVT

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

Very big thank you to YOU for all this work, it made the SSRS deployment so much easier! Agree with your comments and those changes should now be applied.

@mmajcica

This comment has been minimized.

Copy link
Owner

commented Mar 7, 2019

In the README.md hidden fields are still specified as string. I'll fix this before publishing a new version.

@mmajcica mmajcica closed this Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.