Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when passing in an IDiffer to SideBySideDiffBuilder #71

Closed
tolanj opened this issue Jan 18, 2021 · 0 comments
Closed

Issue when passing in an IDiffer to SideBySideDiffBuilder #71

tolanj opened this issue Jan 18, 2021 · 0 comments

Comments

@tolanj
Copy link

tolanj commented Jan 18, 2021

When using the overload to pass in an IDiffer to the SideBySide model ALL SubPieces appear on all changes. Cause appears to be:

public static SideBySideDiffModel Diff(IDiffer differ, string oldText, string newText, bool ignoreWhiteSpace = true, bool ignoreCase = false, IChunker lineChunker = null, IChunker wordChunker = null)

has lamda (ot, nt, op, np) =>
            {
                var r = differ.CreateDiffs(oldText, newText, false, false, wordChunker ?? WordChunker.Instance);
                BuildDiffPieces(r, op, np, null);
            }

Should be CreateDiffs(ot, nt ......

@tolanj tolanj changed the title Issue when passing in an IDiffer to Side Issue when passing in an IDiffer to SideBySideDiffBuilder Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant