Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart punctuation does not get applied in nested inlines (e.g. emphasis) #10

Closed
neongreen opened this issue Mar 5, 2018 · 5 comments
Closed

Smart punctuation does not get applied in nested inlines (e.g. emphasis) #10

neongreen opened this issue Mar 5, 2018 · 5 comments
Labels
bug

Comments

@neongreen
Copy link
Contributor 

$ mmark --ext-punctuation
*Hello...*
<p><em>Hello...</em></p>

$ mmark --ext-punctuation
Hello...
<p>Hello…</p>
@neongreen
Copy link
Contributor Author

This probably applies to some other extensions that use inlineTrans and blockTrans. Also, this behavior was surprising to me and I think it should be mentioned in the docs for inline/blockTrans.

@neongreen
Copy link
Contributor Author

neongreen commented Mar 5, 2018 •
edited
Loading

I fixed a similar problem in my extensions' code by writing

inlineTrans $ Uniplate.transform $ \case -> ...

but I'm not sure what your preferred solution would be.

@mrkkrp
Copy link
Member

mrkkrp commented Mar 6, 2018

This is a bug in mmark. Similar to what I fixed in version 0.0.5.2 (see here). I'll get to this.

@mrkkrp mrkkrp added the bug label Mar 6, 2018
@mrkkrp
Copy link
Member

mrkkrp commented Mar 6, 2018

Closing in favor of mmark-md/mmark#47.

@mrkkrp mrkkrp closed this as completed Mar 6, 2018
@mrkkrp
Copy link
Member

mrkkrp commented Mar 8, 2018

Fixed in mmark-0.0.5.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neongreen @mrkkrp