Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gridsearch-tasks == -1 in args does not perform grid search #7

Open
ashok-arjun opened this issue Aug 7, 2021 · 2 comments
Open

gridsearch-tasks == -1 in args does not perform grid search #7

ashok-arjun opened this issue Aug 7, 2021 · 2 comments

Comments

@ashok-arjun
Copy link

Hello!

Thank you very much for this library - it's great!

I have a question:

The default value of --gridsearch-tasks in main_incremental.py is -1. And it has been given that setting it to -1 will perform grid search for all tasks.

But this does not reflect in the code, and grid search is not done when this is executed.

The only lines where gridsearch_tasks is referenced are line 167, line 214 and line 241 and all of these work only when the value is positive.

Can you please check if the code is right?

Thank you.

@ashok-arjun ashok-arjun changed the title GridSearch == 1 does not perform GridSearch gridsearch-tasks == 1 does not perform grid search Aug 7, 2021
@ashok-arjun ashok-arjun changed the title gridsearch-tasks == 1 does not perform grid search gridsearch-tasks == -1 in args does not perform grid search Aug 7, 2021
@ashok-arjun ashok-arjun changed the title gridsearch-tasks == -1 in args does not perform grid search gridsearch-tasks == -1 in args does not perform grid search Aug 7, 2021
@mkmenta
Copy link
Contributor

mkmenta commented Aug 8, 2021

Hi, thanks for the issue!

I think you are right! I will check it out.

Thank you so much!

(Noting, just in case: setting it to the value of --num-tasks as done here should run the full GridSearch).

@ashok-arjun
Copy link
Author

Thank you @mkmenta. Got it, will use --num-tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants