Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base_args in ffmpeg_transcoder.py make automedia unsuitable for video transcoding. #1

Closed
Dizzy611 opened this issue May 9, 2022 · 4 comments

Comments

@Dizzy611
Copy link

Dizzy611 commented May 9, 2022

I was planning on using automedia for transcoding a bunch of video to x265, however the base args include -vn which drops all video data from any input stream. I'm not sure you want this if automedia is supposed to be for all media, not just music/audio.

@mmastrac
Copy link
Owner

mmastrac commented May 9, 2022

That's a good point. Originally I needed to do this because some album covers are considered video in some audio formats.

I think we could move the arguments to strip video into each of the audio presets. There's no overlap between audio and video transcoding formats, so the preset would determine whether video is included or not.

@mmastrac
Copy link
Owner

This is now fixed, please let me know if that works for you.

@matt-laird
Copy link

Not sure if I understand, inline with the original issue opened, you are forced to only pass in audio related presets into the transcode command. On all versions released, is this intentional at the moment, is the tool only able to work with audio files?

@mmastrac
Copy link
Owner

At the moment, the tool only works with audio files but the code should now support video-capable transcoding. I haven't tested it, but the flags that strip output video are no longer passed automatically, and it should be a matter of creating a preset for the video format you'd like to use.

https://github.com/mmastrac/automedia/blob/main/src/automedia/ffmpeg_transcoder.py#L19

I could probably add a custom transcoding command where the user is given much more control over the flags passed... would that be helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants