Netplay issues in alpha

[mmatyas]

This issue is for collecting netplay-related bugs discovered during the alpha testing.

Todo:

• Pause doesn't work (the windows shows up but nothing pauses)
• When the game finishes and one player exits it just keeps going... it should exit for both.
• Connect dialog stucks right after adding a new entry

Outdated, needs verification:

• Sometimes one character freezes in place
• Once the game ends because there is a lag, when the ending music finally catches up with the second player it will falsely make the second player the winner (after they've been frozen in the top left corner for some time) then they will freeze in place with the winner banners popping off of them. (sprite still moves but they are just locked in one spot)
• if the player hosting joins through their external ip, they attempt to connect using some sort of lan ip. connecting through localhost is fine?

Done:

• Skins don't show up on the other player's build- it defaults to mario
• Gamepad controls don't save
• Fullscreen crashes on SDL2 build (when you press enter in the menu while you have fullscreen selected)
• Sometimes you float through blocks
• After you create a room once and exit out of it and try and enter the same room, it has an infinite joining.... notification. you have to reboot to get it to work
• When there is exactly one block of space between the ground and a [?]-block, hitting that only activates it for the room's host.
• if you join a room you're "locked" to that room, all attempts to join another room result in you joining that room, even if it's invalid
• Skins aren’t always assigned to proper player. (ie. player 2 had player 3's chosen skin, and vice versa)
• rooms don't work with more than two players, seems to duplicate ips of player 2?
• SDL2 still Crashes/Freezes when in fullscreen on my Raspberry PI 2. It doesn't crash with SDL1.
• no netplay bot support yet -> moved to Add netplay bot support #50
• when using a map other than the default it seems it only shows the background image not the platforms (on the client- they are visible on the host)
• Map previews don’t work for clients. They see the default 0smw map.
• In my case- I'm running my pc build on the local network and hosting the server on the pc. if I try and create a room from the pi it segfaults and exits out when I try and type in the new room name, but I can create a room fine from the pc (minus the aforementioned issues)
• Gamemode settings are selected randomly at the start, like when you start a quick game. This causes, for example, that players don't die when killed (they don't respawn, just lose health).
• sometimes when you squish someone they don't visibly squish or respawn- it just keeps going though they do have the momentary invincibility that happens during respawn. It does make the squish sound though and does take away a life.
• perhaps have a notification when someone leaves the room/ automatically exit out if there is only one player
• Need to implement tileset sharing for more varied map sharing. -> moved to Add map tileset sharing to netplay #54
• Can't use items/ the other player doesn't see them (like fire flowers)
• Music isn't Synced (not sure if it should be or not) -> No
• If player 1 is eliminated, player 2 assumes their skin.
• whoever is set as host will have an input lag of 1-2 seconds

[mmatyas]

HerbFargus commented 2 days ago:

Initial Netplay Issues:

• Music isn't Synced (not sure if it should be or not)
• Pause doesn't work (the windows shows up but nothing pauses (also the pause text is offset too far to the left)
• Skins don't show up on the other player's build- it defaults to mario
• Can't use items/ the other player doesn't see them (like fire flowers)
• Gamepad controls don't save
• Fullscreen crashes on SDL2 build (when you press enter in the menu while you have fullscreen selected) Not sure if this is related to the retropie build specifically though.
• Sometimes you float through blocks
• Sometimes one character freezes in place
• When the game finishes and one player exits it just keeps going... it should exit for both.
• no netplay bot support yet

[mmatyas]

Ronoh55 commented a day ago

One more issue possibly related to floating through blocks.

Sometimes when a player breaks a block the graphic for it remains on the other's screen, but it is inactive (i.e. You can jump/fall straight through it). Sometimes going through that block causes a small lag or "float" through the box.

[mmatyas]

mmatyas commented a day ago:

Yeah, most of these are because it's still alpha. The following can be considered bugs though:

• Gamepad controls don't save: that's a bug, thanks!
• Fullscreen crashes on SDL2 build
• Sometimes one character freezes in place: could you tell more details?

[HerbFargus]

• When flying with a feather or pow hand if you get too high you die
• (sometimes) when you squish someone they don't visibly squish or respawn- it just keeps going though they do have the momentary invincibility that happens during respawn. It does make the squish sound though and does take away a life.
• perhaps have a notification when someone leaves the room/ automatically exit out if there is only one player
• After you create a room once and exit out of it and try and enter the same room, it has an infinite joining.... notification. you have to reboot to get it to work
• In my case- I'm running my pc build on the local network and hosting the server on the pc. if I try and create a room from the pi it segfaults and exits out when I try and type in the new room name, but I can create a room fine from the pc (minus the aforementioned issues)
• Once the game ends because there is a lag, when the ending music finally catches up with the second player it will falsely make the second player the winner (after they've been frozen in the top left corner for some time) then they will freeze in place with the winner banners popping off of them. (sprite still moves but they are just locked in one spot)
• when using a map other than the default it seems it only shows the background image not the platforms (on the client- they are visible on the host)

[mmatyas]

• When there is exactly one block of space between the ground and a [?]-block, hitting that only activates it for the room's host.

[Dude00]

• if you join a room you're "locked" to that room, all attempts to join another room result in you joining that room, even if it's invalid
• if the player hosting joins through their external ip, they attempt to connect using some sort of lan ip. connecting through localhost is fine?
• rooms don't work with more than two players, seems to duplicate ips of player 2?
  

[Cyantext]

At 1:16 in this video (https://www.youtube.com/watch?v=9MFRJI_Gpuc) me and herbfargus were trying to start a game and I got a message saying "[Warning] An unexpected client is trying to join the game". From what I could gather nobody had seen that message before and I could never get it to show up again.

I'll write up a full list of issues we had tomorrow, but that was definitely the strangest thing.

[mmatyas]

• Gamemode settings are selected randomly at the start, like when you start a quick game. This causes, for example, that players don't die when killed (they don't respawn, just lose health).

[Ronoh55]

Bugs associated with map previews, map/skin sharing.

1. Map previews don’t work for clients. They see the default 0smw map.
2. Skins aren’t always assigned to proper player. (ie. player 2 had player 3's chosen skin, and vice versa)
3. If player 1 is eliminated, player 2 assumes their skin.
4. Need to implement tileset sharing for more varied map sharing.

[mmatyas]

Skins aren’t always assigned to proper player. (ie. player 2 had player 3's chosen skin, and vice versa)

This should be fixed now, could you test it?

[Ronoh55]

Probably won't get a chance to until Wednesday, but I will test soon.

[mmatyas]

Should be fixed now:

• After you create a room once and exit out of it and try and enter the same room, it has an infinite joining.... notification. you have to reboot to get it to work
• if you join a room you're "locked" to that room, all attempts to join another room result in you joining that room, even if it's invalid
• Skins aren’t always assigned to proper player. (ie. player 2 had player 3's chosen skin, and vice versa)

[HerbFargus]

SDL2 still Crashes/Freezes when in fullscreen on my Raspberry PI 2. It doesn't crash with SDL1.

It isn't really an issue so much as there is no visible difference between windowed and fullscreen on RetroPie since the runcommand script in RetroPie allows for loading screen resolutions dynamically and may very well be a factor that is causing full screen option to crash.

it is now fixed

[mmatyas]

• Connect dialog stucks right after adding a new entry

[HerbFargus]

whoever is set as host will have an input lag of 1-2 seconds