New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Typescript fixes #121
fix: Typescript fixes #121
Conversation
Thank you @SimpleCreations ! 🧡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is looking solid.
Thank you for going above and beyond the TypeScript fixes!
I'll give it a quick run in a couple of hours and then I'll release it.
Wondering if this should be a major bump or not.
At a first glance, I'm not seeing cases where we're making existing types more strict. But normally, when we do these many type changes in a single shot, I prefer doing major releases to ensure we don't break existing build type-checks.
What do you think?
buttonSeparatorStyle, | ||
]} | ||
/> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I think I haven't read this flow in ages, it's 4 years old — no idea why the strings were hardcoded in the first place, haha.
Thank you so much for cleaning this up!
I don't see a major version bump being necessary because yes, seems like we're only making the types less strict. However I don't have experience maintaining public npm packages so I'm not sure about the potential pitfalls. |
# [9.0.0](v8.2.0...v9.0.0) (2021-09-08) ### Bug Fixes * Typescript updates ([#121](#121)) ([1ba6f16](1ba6f16)) ### BREAKING CHANGES * Updated TypeScript type definitions. Types _should_ just be more relaxed now — but since we updated the entire codebase we'll release this a major bump to be safe.
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
ColorValue
instead ofstring