Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unstableLabelStyle & fix switch statement comparison method #150

Merged
merged 9 commits into from Oct 31, 2022

Conversation

Nantris
Copy link
Contributor

@Nantris Nantris commented Oct 29, 2022

@mmazzarolo sorry for the huge delay - I'm finally getting around to this!

This PR:

  1. Adds unstableLabelStyle (Add unstableLabelStyle #144)
  2. Changes comparisons on .type to .type?.displayName (Determine where children belong using .displayName #143)
  3. Fixes TypeScript complaints that predate this work (although I later rebased the changes not having realized there was a 9.2.2 release, so maybe irrelevant)

I made the new PR to avoid having to do any force pushes after the rebase.

I've tested this branch in our application and it works as intended in my testing (although, trivial difference, to test it had to change "main": "lib/index.js" "main": "src/index.ts" to work around no postinstall for packages installed from git commits)

Please let me know if you see any remaining issues and I'll get those squared away, but I think there are none.

Sorry again for the delay!

@Nantris Nantris changed the title Unstable label style final Add unstableLabelStyle & fix switch statement comparison method Oct 29, 2022
Copy link
Owner

@mmazzarolo mmazzarolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @slapbox ! 🙌 No worries about delays, etc. I've also been very slow to respond :D

@mmazzarolo mmazzarolo merged commit 839915b into mmazzarolo:master Oct 31, 2022
github-actions bot pushed a commit that referenced this pull request Oct 31, 2022
# [9.3.0](v9.2.2...v9.3.0) (2022-10-31)

### Features

* Add unstableLabelStyle & fix switch statement comparison method ([#150](#150)) ([839915b](839915b))
@github-actions
Copy link

🎉 This PR is included in version 9.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants