(fix)(refactor) Memo'd component to avoid re-rendering upstream which has a bug #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was trying to debug an issue with value being reset, but it appears to have come from downstream
so that it only renders the underlying DateTimePicker once (or on date change)
mmazzarolo
approved these changes
Aug 3, 2020
|
Looks good to me, thank you @lukemcgregor ! Gonna test it and merge it :) |
mmazzarolo
pushed a commit
that referenced
this pull request
Aug 4, 2020
# [8.8.0](v8.7.1...v8.8.0) (2020-08-04) ### Features * Memo'd Android component to avoid re-rendering upstream which has a bug ([#453](#453)) ([069b2ca](069b2ca))
|
🎉 This PR is included in version 8.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fixes #451, This PR memos the component to avoid triggering a re-render of the upstream library @react-native-community/datetimepicker which recreates the date picker on each render call. I have also converted to hooks while working out how to resolve this issue.