feat: Add cancelButtonTestID and confirmButtonTestID props for e2e te… #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @kanelloc , could you also update the README? |
mmazzarolo
approved these changes
Jul 13, 2021
Sure!! |
…al-datetime-picker into buttons-testID
|
@mmazzarolo I updated README with both props. |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
# [10.1.0](v10.0.0...v10.1.0) (2021-07-13) ### Features * Add `cancelButtonTestID` and `confirmButtonTestID` props ([#582](#582)) ([73a4874](73a4874))
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@kanelloc Am I right in saying it is not currently possible to attach a |
The above implementation is only for iOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support with e2e testing for 'submit' and 'cancel' buttons.