Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display prop typscript issue #636

Conversation

matthewparavati
Copy link
Contributor

Overview

Fix for #567
Pulls in changes from #585, along with the requested changes in that PR

Test Plan

Followed @mmazzarolo's suggestion in other PR to create a new project, add date picker, and add changes to index.d.ts
some screen shots below:

display options available
available_display_options

inline display option used, no ts error
inline_used_no_ts_error

@matthewparavati matthewparavati marked this pull request as ready for review March 29, 2022 23:45
Copy link
Owner

@mmazzarolo mmazzarolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @matthewparavati :) Merging!

@mmazzarolo mmazzarolo merged commit 1fd3755 into mmazzarolo:master Mar 30, 2022
github-actions bot pushed a commit that referenced this pull request Mar 30, 2022
## [13.1.1](v13.1.0...v13.1.1) (2022-03-30)

### Bug Fixes

* `display` prop TypeScript issue ([#636](#636)) ([1fd3755](1fd3755))
@github-actions
Copy link

🎉 This PR is included in version 13.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matthewparavati matthewparavati deleted the matthewparavati/display-prop-typescript-fix branch March 30, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants