fix: omitted underlying onChange prop type #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmazzarolo
approved these changes
Dec 20, 2022
|
Makes sense, thank you! |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
## [14.0.1](v14.0.0...v14.0.1) (2022-12-20) ### Bug Fixes * **types:** omitted underlying onChange prop type ([#680](#680)) ([b02409d](b02409d))
|
🎉 This PR is included in version 14.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The prop onChange was being interpreted as an union between the onChange prop of this library and the onChange prop of
@react-native-community/datetimepicker. I ommited this key because Typescript was expecting a callback with two params (event, date) instead of just one as this library says it should receive (only date).