fix: resolve occasional styling bug with inline display in datetime mode on iOS #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmazzarolo
approved these changes
Apr 8, 2023
| @@ -50,7 +50,7 @@ | |||
| "semantic-release": "^17.1.2" | |||
| }, | |||
| "peerDependencies": { | |||
| "@react-native-community/datetimepicker": ">=3.0.0", | |||
| "@react-native-community/datetimepicker": ">=6.7.0", | |||
I don't — hard for me to focus on improving it nowadays. Contributions are warmly welcome! If the contributions become more than occasional I'm also open to share the ownership officially and/or move it to a shared org. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2023
# [15.0.0](v14.0.1...v15.0.0) (2023-04-08) ### Bug Fixes * resolve occasional styling bug with inline `display` in `datetime` mode on iOS ([#697](#697)) ([8733f83](8733f83)) ### BREAKING CHANGES * This is a light breaking change since it might break custom patches people applied to fix this issue in other way + we're bumping the `@react-native-community/datetimepicker` peer-dependency version
|
🎉 This PR is included in version 15.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Released @fobos531 , thanks so much for contributing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Continuing on from our discussion #672, the aim of this PR is to provide a temporary resolution of the occasional styling bug with inline display in datetime mode on iOS. More context is in the linked issue. When testing, I found that 370 is the most appropriate value with the current default styles of the picker. However, after more tinkering, I discovered that applying various other styles to the picker, e.g.
modalStyleIOSandpickerStyleIOS, it could affect the efficiency of this "fix". With that said, this will work IF the users use the default styles provided by this library. For cases when they provide more of their own styles, apickerComponentStyleIOSprop is now exposed which they can use to overwrite the fix applied in this PR. I'm not sure if this is the best approach, but I felt it was necessary to cover all cases.Test Plan
See: #672 (comment)
Please let me know if you feel any modifications need to be made here.
Side question: do you have any plans/roadmap on making tweaks to this library in general in the near future? I saw it could use some love (e.g. by default incorrect padding, insets are being taken into account on iPhone 14 pro etc.), so I was wondering if this is something you plan on working on already or you're looking for community contributions for it.