Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: The Confirm button stays disabled on singe tap (no drag) #82

Closed
zubko opened this issue Aug 30, 2017 · 6 comments
Closed

iOS: The Confirm button stays disabled on singe tap (no drag) #82

zubko opened this issue Aug 30, 2017 · 6 comments
Labels

Comments

@zubko
Copy link

zubko commented Aug 30, 2017

Using latest: v4.10.0

The button become disabled on onStartShouldSetResponderCapture, but then the value didn't change, so the button doesn't become enabled.

I've tried to put the handler to onMoveShouldSetResponderCapture, at least it's triggered when some movement happens. It's still possible that Confirm will stay disabled but the margin for error is smaller. Single taps won't cause the issue.

Ideally I think the button should become disabled when the drag distance is big enough, but unfortunately I don't have time for finetunning a 100% fix and PR, so I'm just reporting.

@mmazzarolo
Copy link
Owner

@zubko thank you for the report, I'll take a look at it as soon as I have some free time.
Anyone else having the same issue?

@mmazzarolo mmazzarolo added the bug label Aug 30, 2017
@thurber
Copy link
Contributor

thurber commented Oct 13, 2017

I'm also experiencing this issue... if a user taps on the value that is already selected, the confirm button remains disabled until they change the value.

What's the reason for disabling the confirm button at all?

@mmazzarolo
Copy link
Owner

@thurber might be related to #40, what do you think?

@thurber
Copy link
Contributor

thurber commented Oct 17, 2017

I see, so it prevents confirming while the wheel is actively in motion, so that an old value isn't confirmed. That makes sense, but unfortunately my users are getting confused. ^_^;

Any chance you'd be open to adding a prop to disable this behavior? I'd be happy to PR it.

@mmazzarolo
Copy link
Owner

Of course! Just remember to not update the README.md

@mmazzarolo
Copy link
Owner

Should be fixed in the new v4.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants