-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: The Confirm button stays disabled on singe tap (no drag) #82
Comments
@zubko thank you for the report, I'll take a look at it as soon as I have some free time. |
I'm also experiencing this issue... if a user taps on the value that is already selected, the confirm button remains disabled until they change the value. What's the reason for disabling the confirm button at all? |
I see, so it prevents confirming while the wheel is actively in motion, so that an old value isn't confirmed. That makes sense, but unfortunately my users are getting confused. ^_^; Any chance you'd be open to adding a prop to disable this behavior? I'd be happy to PR it. |
Of course! Just remember to not update the README.md |
Should be fixed in the new v4.13.0 |
Using latest: v4.10.0
The button become disabled on
onStartShouldSetResponderCapture
, but then the value didn't change, so the button doesn't become enabled.I've tried to put the handler to
onMoveShouldSetResponderCapture
, at least it's triggered when some movement happens. It's still possible that Confirm will stay disabled but the margin for error is smaller. Single taps won't cause the issue.Ideally I think the button should become disabled when the drag distance is big enough, but unfortunately I don't have time for finetunning a 100% fix and PR, so I'm just reporting.
The text was updated successfully, but these errors were encountered: