Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error parsing non-utf8 feeds #21

Closed
terryh opened this issue Apr 15, 2016 · 9 comments · Fixed by #22 or #58
Closed

Error parsing non-utf8 feeds #21

terryh opened this issue Apr 15, 2016 · 9 comments · Fixed by #22 or #58
Labels

Comments

@terryh
Copy link

terryh commented Apr 15, 2016

rss_feed with this xml encoding detect error

<title>RSS Title</title>
@mmcdole
Copy link
Owner

mmcdole commented Apr 15, 2016

@terryh can you post a link to the feed?

@terryh
Copy link
Author

terryh commented Apr 15, 2016

Yes, no problem.
https://feodotracker.abuse.ch/feodotracker.rss

@mmcdole
Copy link
Owner

mmcdole commented Apr 15, 2016

@terryh thanks, this should be an easy fix. It will require an interface change to mmcdole/goxpp, but that is alright.

Let me work on it some.

@mmcdole mmcdole changed the title Feed detect error Error parsing non-utf8 feeds Apr 15, 2016
@mmcdole mmcdole added the bug label Apr 15, 2016
@mmcdole mmcdole reopened this Apr 15, 2016
@mmcdole
Copy link
Owner

mmcdole commented Apr 15, 2016

@terryh please try again with the latest from the master branch.

Don't forget to go get the latest deps as this fix required a change in goxpp.

@KlonD90
Copy link

KlonD90 commented Aug 27, 2016

It doesn't work for
http://sled-udmproc.ru/rss
._.

@mmcdole
Copy link
Owner

mmcdole commented Aug 27, 2016

Thanks for the report. Looking into charset handling.

Sent from my iPhone

On Aug 27, 2016, at 9:53 AM, Nick notifications@github.com wrote:

It doesn't work for
http://sled-udmproc.ru/rss
._.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

@mmcdole
Copy link
Owner

mmcdole commented Aug 27, 2016

@KlonD90 looks like the issue is with my sanitize function. If I remove that it parses fine:

https://github.com/mmcdole/gofeed/blob/master/rss/parser.go#L19

That code was put in to strip "illegal" characters to fix #25. Need to see how to resolve this issue in a way that it fixes both problems.

@mmcdole
Copy link
Owner

mmcdole commented Aug 27, 2016

@KlonD90 can you get latest and try again? Your feed is working now.

@mmcdole mmcdole reopened this Aug 27, 2016
@KlonD90
Copy link

KlonD90 commented Aug 27, 2016

@mmcdole
Thank you. It's work for me :o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants