Skip to content

Commit

Permalink
Blidly retrying may be usafe.
Browse files Browse the repository at this point in the history
  • Loading branch information
mmcgrana committed Jan 9, 2010
1 parent b9e565b commit e4d47cf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
2 changes: 1 addition & 1 deletion fleet.gemspec
@@ -1,6 +1,6 @@
Gem::Specification.new do |s| Gem::Specification.new do |s|
s.name = "fleet" s.name = "fleet"
s.version = "0.1.6" s.version = "0.1.7"


s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version= s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
s.authors = ["Mark McGranaghan"] s.authors = ["Mark McGranaghan"]
Expand Down
12 changes: 1 addition & 11 deletions lib/fleet.rb
Expand Up @@ -18,7 +18,7 @@ def initialize(options = {})


def query(q) def query(q)
request = @json_encoder.encode(q) request = @json_encoder.encode(q)
response = write_and_read_with_retry(request) response = write_and_read(request)
status, value = @json_parser.parse(response) status, value = @json_parser.parse(response)
case status case status
when 0 when 0
Expand Down Expand Up @@ -57,16 +57,6 @@ def disconnect
@socket = nil @socket = nil
end end


def write_and_read_with_retry(request)
begin
write_and_read(request)
rescue Errno::ECONNRESET, Errno::EPIPE, Errno::ECONNABORTED, Timeout::Error
disconnect
connect
write_and_read(request)
end
end

def write_and_read(request) def write_and_read(request)
with_timeout do with_timeout do
@socket.write(request) @socket.write(request)
Expand Down

0 comments on commit e4d47cf

Please sign in to comment.