Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie parsing needs to deal with nil return value from url-decode #51

Closed
cch1 opened this issue Feb 3, 2012 · 0 comments
Closed

Cookie parsing needs to deal with nil return value from url-decode #51

cch1 opened this issue Feb 3, 2012 · 0 comments
Milestone

Comments

@cch1
Copy link

cch1 commented Feb 3, 2012

The decision to allow url-decode to return nil for improperly encoded strings (instead of throwing an exception) now means that cookie handling needs to accomodate this newly-endorsed return value.

Frankly, I think raising an exception was the right behavior, but since nil is now a valid return value, the normalize-quoted-strs function now fails with an NPE if any cookie value cannot be decoded.

bendlas referenced this issue in bendlas/ring Mar 26, 2013
Bump Clojure version in 1.5 profile up to 1.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants