Cookie parsing needs to deal with nil return value from url-decode #51

Closed
cch1 opened this Issue Feb 3, 2012 · 0 comments

Comments

Projects
None yet
2 participants
@cch1

cch1 commented Feb 3, 2012

The decision to allow url-decode to return nil for improperly encoded strings (instead of throwing an exception) now means that cookie handling needs to accomodate this newly-endorsed return value.

Frankly, I think raising an exception was the right behavior, but since nil is now a valid return value, the normalize-quoted-strs function now fails with an NPE if any cookie value cannot be decoded.

bendlas referenced this issue in bendlas/ring Mar 26, 2013

Merge pull request #51 from kavu/upate_clojure_version
Bump Clojure version in 1.5 profile up to 1.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment