Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash2properties PR #18

Closed
droopy4096 opened this issue Mar 10, 2018 · 3 comments
Closed

hash2properties PR #18

droopy4096 opened this issue Mar 10, 2018 · 3 comments

Comments

@droopy4096
Copy link

I found hash2stuff very useful however I was missing Java properties file management, so I've added one: PR #17

One of the tests fails (puppet 4.0) but it fails across the board so it either needs to be dropped or refactored (or just let me know what could be done on my end to get PR accepted).
@mmckinst
Copy link
Owner

mmckinst commented May 1, 2018

I've commented on the PR. I think your code should work as is but can you squash the commits?

@droopy4096
Copy link
Author

done. squashed commits.

@mmckinst
Copy link
Owner

mmckinst commented May 5, 2018

Thank you very much for the PR! Sorry for the long delay in getting it meregd.

@mmckinst mmckinst closed this as completed May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@droopy4096 @mmckinst