Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/thirdparty: add probakowski/curve1174 #245

Open
mmcloughlin opened this issue Apr 11, 2022 · 2 comments · May be fixed by #248
Open

tests/thirdparty: add probakowski/curve1174 #245

mmcloughlin opened this issue Apr 11, 2022 · 2 comments · May be fixed by #248
Labels
testing Tests and supporting infrastructure

Comments

@mmcloughlin
Copy link
Owner

https://github.com/probakowski/curve1174

@mmcloughlin mmcloughlin added the testing Tests and supporting infrastructure label Apr 11, 2022
@mmcloughlin
Copy link
Owner Author

@probakowski See #248 for a PR that adds your repository to the third-party compatibility test suite for avo. Unfortunately, the test failed in Github Actions with an illegal instruction exception. Usually this happens when some code isn't doing the right CPU feature checks.

I'd be grateful if you could take a look and give your assessment of what's going wrong. Thanks!

@mmcloughlin mmcloughlin linked a pull request Apr 18, 2022 that will close this issue
@Yawning
Copy link

Yawning commented May 2, 2022

@probakowski See #248 for a PR that adds your repository to the third-party compatibility test suite for avo. Unfortunately, the test failed in Github Actions with an illegal instruction exception. Usually this happens when some code isn't doing the right CPU feature checks.

I'd be grateful if you could take a look and give your assessment of what's going wrong. Thanks!

Chiming in from the peanut gallery, the assembly mulD and sqr use ADX and BMI2 unconditionally, with the CI test choking in the latter. So indeed this needs fallback code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Tests and supporting infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants