Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move empty query param handling to base http call methods #147

Closed
mmenanno opened this issue Jan 28, 2024 · 0 comments · Fixed by #157
Closed

Move empty query param handling to base http call methods #147

mmenanno opened this issue Jan 28, 2024 · 0 comments · Fixed by #157
Labels
code cleanup

Comments

@mmenanno
Copy link
Owner

This pattern occurs frequently in the code and could be improved by handling empty query params right at our base http methods like get

response = if params.empty?
  get("transactions")
else
  get("transactions", query_params: params)
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup
Projects
LunchMoney Ruby Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle empty params directly in get method mmenanno/lunchmoney
1 participant
@mmenanno