Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical pathnames are not translated #40

Closed
Ambrevar opened this issue Jun 17, 2022 · 3 comments · Fixed by #41
Closed

Logical pathnames are not translated #40

Ambrevar opened this issue Jun 17, 2022 · 3 comments · Fixed by #41

Comments

@Ambrevar
Copy link
Contributor

Ambrevar commented Jun 17, 2022

Reporting warnings and errors when compiling logical pathnames results in the *sly-compilation* buffer listing the logical pathnames (e.g. SYS:SRC;foo.lisp) instead of the physical path. Calling next-error or clicking on the compiler note then results in the source not being found.

Easy fix:

(defun replace-location-if-error (location)
  (if (and (eq (car location) :error)
           *current-source-file*)
      (slynk-backend:make-location
       `(:file ,(namestring (translate-logical-pathname (asdf:component-pathname *current-source-file*))))
       `(:position 0))
      location))
@Ambrevar
Copy link
Contributor Author

Ambrevar commented Jul 3, 2022

Friendly ping @mmgeorge :)
Should I send a pull request?

@mmgeorge
Copy link
Owner

mmgeorge commented Jul 4, 2022

Sorry @Ambrevar, I don't do much common lisp programming these days, so I've been slow to get to this.

PRs always welcome!

@Ambrevar
Copy link
Contributor Author

Ambrevar commented Jul 5, 2022

Thanks and done with #41 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants