Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with firstWeekday. The header is not updating. #99

Closed
jfbomber opened this issue Nov 21, 2019 · 17 comments
Closed

Issue with firstWeekday. The header is not updating. #99

jfbomber opened this issue Nov 21, 2019 · 17 comments

Comments

@jfbomber
Copy link

For the CalendarView when I set the first day of the week variable to Sunday it is updating the calendar days correctly but not the header at the top.

self.calendarView.style.firstWeekday = .sunday
self.calendarView.style.locale = Locale(identifier: "en_US")

Simulator Screen Shot - iPhone 11 - 2019-11-21 at 08 38 04

@azeemgujjar
Copy link

Hi i am facing the same issue, did you get solution? or fix for this bug?

@mudassarahmad09
Copy link

I'm experiencing the same problem. @mmick66, do you have any advice for how to solve this issue?

@mmick66
Copy link
Owner

mmick66 commented Dec 12, 2019

I’m going to have a look.

@azeemgujjar
Copy link

I’m going to have a look.

Awesome, will be thankful if you can fix issue or suggest some hack quickly..

@azeemgujjar
Copy link

Hi @mmick66 any update with this issue? when are you going to fix this bug

@mmick66
Copy link
Owner

mmick66 commented Dec 20, 2019

Today, I promise!

@azeemgujjar
Copy link

Actually this is very embarrassing i used your library and already demonstrate to client, now can't even remove your library and use native calendar.. and this is around 30 days old issue. and still not fixed.

@mmick66
Copy link
Owner

mmick66 commented Dec 20, 2019

Screenshot 2019-12-20 at 10 25 32

Have a look above. I can't really seem to be able to reproduce it. Could it be a version thing? How are you installing it?

@azeemgujjar
Copy link

change header to starting to sunday
then when calendar open first time it will show wrong dates order.

@mmick66
Copy link
Owner

mmick66 commented Dec 20, 2019

Screenshot 2019-12-20 at 10 51 41

This is what I'm seeing...

@mmick66
Copy link
Owner

mmick66 commented Dec 20, 2019

Actually this is very embarrassing i used your library and already demonstrate to client, now can't even remove your library and use native calendar.. and this is around 30 days old issue. and still not fixed.

I am not suggesting you remove the component! I am asking whether you have the right version. I had merged some pull requests around the time you raised the issue. As you can see from above, I am not able to reproduce it. Can you please check you are on the latest version of the component?

@azeemgujjar
Copy link

azeemgujjar commented Dec 20, 2019

KDCalendar 1.8.3
install by pod

@mmick66

  • To produce just change starting day to .Sunday
  • when calender first time open it will show selected date to yesterday.
  • next time it will work normally.
  • to reproduce exit application and repeat

@azeemgujjar
Copy link

Actually this is very embarrassing i used your library and already demonstrate to client, now can't even remove your library and use native calendar.. and this is around 30 days old issue. and still not fixed.

I am not suggesting you remove the component! I am asking whether you have the right version. I had merged some pull requests around the time you raised the issue. As you can see from above, I am not able to reproduce it. Can you please check you are on the latest version of the component?

Ok Thank you so much i am just going to try this

@mmick66
Copy link
Owner

mmick66 commented Dec 20, 2019

Please let me know. I really want to get to the bottom of this.

@mmick66
Copy link
Owner

mmick66 commented Dec 22, 2019

KDCalendar 1.8.3
install by pod

@mmick66

  • To produce just change starting day to .Sunday
  • when calender first time open it will show selected date to yesterday.
  • next time it will work normally.
  • to reproduce exit application and repeat

I cannot seem to reproduce. Could you please zip your project and send it here? I will have a look...

@azeemgujjar
Copy link

Hi @mmick66 ,
I apologize for late response, these days i was actually trying to reproduce that bug on my side but till now its working fine. i was removed previous version of library and use your latest commit.

Thank you so much for follow-up i will keep in touch with you and update you if any issue i found.

@mmick66
Copy link
Owner

mmick66 commented Dec 27, 2019

No problem... I'm glad it got resolved.

@mmick66 mmick66 closed this as completed Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants