Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same line action also needs conversion #25

Closed
mmikeww opened this issue Dec 23, 2016 · 3 comments
Closed

Same line action also needs conversion #25

mmikeww opened this issue Dec 23, 2016 · 3 comments

Comments

@mmikeww
Copy link
Owner

mmikeww commented Dec 23, 2016

Split from Issue #3
Related to Issue #14

needs to recurse somehow if the same-line action is another command that needs to be converted:

IfNotEqual leftlist,, SetEnv item, `,%item%

this is wrong:

if (leftlist != ""), SetEnv item, `,%item%

needs to be:

if (leftlist != ""), item := "," . item
@mmikeww
Copy link
Owner Author

mmikeww commented Dec 23, 2016

and what if its another IfCommand chained?

this looks like its valid v1 code:

var = 3
IfEqual, var, 3, IfGreater, var, 1, IfLess, var, 5, MsgBox

and this works in v2:

var := 3
if (var = 3), if (var > 1), if (var < 5), MsgBox

god damnit

@mmikeww
Copy link
Owner Author

mmikeww commented Dec 23, 2016

may need to refactor into smaller funcs so i can recursively call them

@safetycar
Copy link
Contributor

This is no longer possible in v2 if (var = 3), if (var > 1), if (var < 5), MsgBox

But the conversion is done with an indented line jump, so it seems that the issue can be closed.

@mmikeww mmikeww closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants