Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off by one errors sorting edges #5

Open
siler opened this issue Jan 28, 2024 · 0 comments
Open

Off by one errors sorting edges #5

siler opened this issue Jan 28, 2024 · 0 comments

Comments

@siler
Copy link

siler commented Jan 28, 2024

Hello,

I noticed that there seems to be a couple of off by one errors in the edge sorting code. The condition checks here and here need to be <= as opposed to <. It seems that the last element of the edges array is not being sorted into the proper position without this change.

An example array tail before the change:

[ ...
  unnamed { i0: 84, i1: 94, f: 21 }
  unnamed { i0: 89, i1: 94, f: 23 }
  unnamed { i0: 89, i1: 94, f: 22 }
]

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant