Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display site.description in masthead #2173

Closed
jdeluyck opened this issue May 30, 2019 · 4 comments
Closed

Display site.description in masthead #2173

jdeluyck opened this issue May 30, 2019 · 4 comments

Comments

@jdeluyck
Copy link
Contributor

Summary

Allow printing of the subtitle / description of the site below the site title

Motivation

It's just a nice featue that I believe more sites can use. It's like a subnote under your main title, giving you the ability to add an 'afterthought'.

Drawbacks

Can't really think of one.

Code:

I added to main.css:

$type-size-9: 0.350em !default; // ~4px

/* Site Subtitle */
.site-subtitle {
  font-size: $type-size-9;
}

to masthead

        <a class="site-title" href="{{ '/' | relative_url }}">{{ site.masthead_title | default: site.title }}
        <div class="site-subtitle">{{ site.description }}</div></a>

and I guess this could be made optional - for my own use I've just included it as is.

@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Status: Stale label Jun 29, 2019
@iBug
Copy link
Collaborator

iBug commented Jul 1, 2019

Good idea. But what about submitting a PR for this?

@stale stale bot removed the Status: Stale label Jul 1, 2019
@jdeluyck
Copy link
Contributor Author

jdeluyck commented Jul 1, 2019

Sure :) I wasn't sure if you'd be interested.

@mmistakes
Copy link
Owner

@jdeluyck If it's quick to do a PR I'll take a look, but no promises I'll merge it in. I'm trying to reduce the amount optional stuff since the theme is getting really bloated with these sorts of things.

They're easy enough to do custom _includes that override the bundled theme's if you wish to customize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants