Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make text use the whole page width once below the bottom of the author block #100

Closed
lesaint opened this issue Nov 14, 2014 · 4 comments
Closed

Comments

@lesaint
Copy link

lesaint commented Nov 14, 2014

Hi, this is a feature request and a feasibility question.

Is it complex to make the text of blog posts to use the whole width of the page once it goes lower than the bottom of the author block?

I fear that it would be hard to do so and keep a responsive design, but I am no expert.

Since the responsiveness of the blog is not my first priority, I would also be happy with just a modification suggestion to achieve that result in place of a modification of the theme.

Thank you for your work on this theme, it was quite helpful to me.

@mmistakes
Copy link
Owner

Is something like this what you're after?

float-sidebar

To do it you'll have to modify the source order and some grid related CSS on the author block (entry-meta) and the main content block (entry-content). Basically what I did was move the author block inside the main content, which floats to the left and allows the text to wrap around it.

The way it currently is structured the two sections are independent of each other. Visually I'm not a fan of the wrap so I didn't do it that way. Plus as you mentioned it does get kind of screwy at other screen sizes. Making the content readable on all browsers and devices was my primary goal with the theme.

@lesaint
Copy link
Author

lesaint commented Nov 14, 2014

Thank you for your quick reply.

This is exactly what I meant.

I agree with you, the wrap is not necessarily visually successful.

I was looking for a way of claiming all the space left empty under the author block to use it for the content and improve its display (less scrolling). I though of the wrap solution but there might be others ways to do it.

I tried moving the author block inside the main content (but did not change any CSS) before creating this issue. It globally worked but the author picture wasn't round anymore. Would you mind sharing with me the CSS changed you did?

@mmistakes
Copy link
Owner

You'll have to play with the width/height and border radius on the author image. What I did was just a proof of concept. I didn't touch the CSS and just moved some things around while inspecting the page in Chrome's web developer tools.

@lesaint
Copy link
Author

lesaint commented Nov 14, 2014

Ok, thank you again for you feedback on this, I'll see what I can manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants