Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade redis types. #21

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Conversation

liam-betsworth
Copy link
Contributor

@liam-betsworth liam-betsworth commented Sep 18, 2018

When accessing the base RedisClient in Typescript using

import { createHandyClient } from 'handy-redis';

const handyClient = createHandyClient(6379, "redis");
const redisClient: RedisClient = handyClient.redis;

The current redis types0.12.36 prevent the use of some commands, including batch().

Upgrading the redis types to 2.8.6 fixes this issue

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5d6f713 on liam-betsworth:upgrade-redis-types into 265aacc on mmkal:master.

@mmkal
Copy link
Owner

mmkal commented Sep 20, 2018

Looks good to me - happy to treat this as a non-breaking change since the redis version is 2.8.x.

@mmkal mmkal merged commit 3b43766 into mmkal:master Sep 20, 2018
@liam-betsworth
Copy link
Contributor Author

@mmkal Great stuff. When can we expect to see the next npm release?

@mmkal
Copy link
Owner

mmkal commented Sep 20, 2018

It's supposed to release automatically, looks like something went wrong with semantic release. Will look into it over the weekend.

@mmkal
Copy link
Owner

mmkal commented Sep 21, 2018

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants