Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batching Support #58

Closed
Symbianx opened this issue May 19, 2020 · 4 comments · Fixed by #59
Closed

Batching Support #58

Symbianx opened this issue May 19, 2020 · 4 comments · Fixed by #59

Comments

@Symbianx
Copy link
Contributor

Hello,

We're using this to restore messages from S3 and it's working great for 100k messages. However, we noticed the connector will read all the S3 files before starting to send the messages to the topics. We're afraid of running into memory limitations when we reach higher numbers of messages.

I was wondering if it would be possible to add batching support to this connector?

@mmolimar
Copy link
Owner

Hi!
Yes, it's a good point and the idea is to have that feature in the next minor release.

Thanks for your comments!

@Symbianx
Copy link
Contributor Author

Symbianx commented May 19, 2020

I started something on my fork by creating a new SimpleBatchPolicy that behaves like the SimplePolicy with a config for the number of files to return per execution call (handled in an Iterator).

Still need to get some tests done but wouldn't mind doing the PR for it. Does this align with the plans for the feature?

@mmolimar
Copy link
Owner

mmolimar commented May 19, 2020

Sure! Contribs are very welcome!
Anyway, I'd think in something more generic to apply to all policies/file readers.

@Symbianx
Copy link
Contributor Author

Symbianx commented May 20, 2020

Created the PR #59. Since this is related to batching of files (not messages) I think it should be a functionality in policies instead of file readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants