Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asynchronous exceptions on Windows can lead to a crash #7

Closed
mmomtchev opened this issue Sep 8, 2023 · 3 comments · Fixed by #8
Closed

Asynchronous exceptions on Windows can lead to a crash #7

mmomtchev opened this issue Sep 8, 2023 · 3 comments · Fixed by #8

Comments

@mmomtchev
Copy link
Owner

The problem seems to be in SWIG
@mmomtchev
Copy link
Owner Author

mmomtchev commented Sep 8, 2023 •
edited

Related to copying Magick::Exceptions across shared library boundaries on Windows.

Strong suspicion of being a compiler/runtime issue.

@mmomtchev
Copy link
Owner Author

Found to be caused by different compilation options between the Node.js addon the ImageMagick libraries causing a difference in sizeof(Magick::Exception) between the two.

@mmomtchev mmomtchev reopened this Sep 10, 2023
@mmomtchev
Copy link
Owner Author

mmomtchev commented Sep 10, 2023 •
edited

Caused by node-gyp adding the _HAS_EXCEPTIONS=0 macro reducing the size of std::exception from 24 bytes to 16 bytes

@mmomtchev mmomtchev mentioned this issue Sep 10, 2023
Merged
@mmomtchev mmomtchev mentioned this issue Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix a memory corruption with MSVC mmomtchev/magickwand.js
1 participant
@mmomtchev