Tests reproducing #96 Handle optional parameters for constructor/meth…

…od injection
PHP-DI · Aug 13, 2013 · 4d1fb05 · 4d1fb05
1 parent 7a48aec
commit 4d1fb05
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/DI/Factory.php b/src/DI/Factory.php
@@ -116,6 +116,7 @@ private function injectConstructor(ReflectionClass $classReflection, MethodInjec
                     . "' of the constructor of '{$classReflection->name}' has no type defined or guessable");
             }
 
+            // TODO handle lazy injections!
             $args[] = $this->container->get($entryName);
         }
 

diff --git a/tests/IntegrationTests/DI/Fixtures/Class1.php b/tests/IntegrationTests/DI/Fixtures/Class1.php
@@ -62,20 +62,30 @@ class Class1
     /**
      * @param Class2     $param1
      * @param Interface1 $param2
+     * @throws \Exception
      */
-    public function __construct(Class2 $param1, Interface1 $param2)
+    public function __construct(Class2 $param1, Interface1 $param2, $optional = true)
     {
         $this->constructorParam1 = $param1;
         $this->constructorParam2 = $param2;
+
+        if ($optional !== true) {
+            throw new \Exception("Expected optional parameter to not be defined");
+        }
     }
 
     /**
      * @Inject
      * @param Class2 $param1
+     * @throws \Exception
      */
-    public function method1(Class2 $param1)
+    public function method1(Class2 $param1, $optional = true)
     {
         $this->method1Param1 = $param1;
+
+        if ($optional !== true) {
+            throw new \Exception("Expected optional parameter to not be defined");
+        }
     }
 
     /**