[WIP] Refactoring of the definition sources #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition sources are, as of today, a source of frustration and limitations. They make #136 very difficult for v4.0.
This is a refactoring where, instead of a DefinitionManager having a CombinedSource in which sources are added in a precise order, the sources will be chained.
So:
AnnotationDefinitionSource
will completely replaceReflectionDefinitionSource
when annotations are enabled, this is too much trouble for no less lines of code elseMergeableDefinition
TODO left:
ArrayDefinitionSource
to separate reading a file from managing an array of definitions