Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring of the definition sources #140

Merged
merged 10 commits into from Dec 12, 2013
Merged

Conversation

mnapoli
Copy link
Member

@mnapoli mnapoli commented Dec 10, 2013

The definition sources are, as of today, a source of frustration and limitations. They make #136 very difficult for v4.0.

This is a refactoring where, instead of a DefinitionManager having a CombinedSource in which sources are added in a precise order, the sources will be chained.

So:

  • There will be a "chain" of sources (easier to handle)
  • AnnotationDefinitionSource will completely replace ReflectionDefinitionSource when annotations are enabled, this is too much trouble for no less lines of code else
  • introduction of a MergeableDefinition
  • no more merging with parents in array/PHP definitions -> an entry is identified by its entry name, its class name is either defined or guess from the entry name, period

TODO left:

  • Refactor ArrayDefinitionSource to separate reading a file from managing an array of definitions

@ghost ghost assigned mnapoli Dec 10, 2013
mnapoli added a commit that referenced this pull request Dec 12, 2013
@mnapoli mnapoli merged commit 0edef76 into 4.0 Dec 12, 2013
@mnapoli mnapoli deleted the DefinitionSourceRefactoring branch December 12, 2013 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant