Renamed Piwik to Matomo #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
j0k3r
reviewed
Apr 23, 2020
README.md
Outdated
|
|
||
| ## Installation | ||
|
|
||
| composer require "mnapoli/piwik-twig-extension" | ||
| composer require "mnapoli/matomo-twig-extension" |
There was a problem hiding this comment.
I don't know if we should update the package name.
It'll require @mnapoli to create a new package, people will be lost, etc.
I think we should keep the same name but only rename classes, etc. as @tcitworld suggested.
I also don't have experience in renaming a composer package, maybe it's more easy than I though
There was a problem hiding this comment.
Hi! It is possible to rename, old package versions will still work, new versions will be available only under the new name. I'm not sure I'll have to create a new package, but I can do that if that helps. It's up to you, but I understand if you want to keep things as they are to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5, #2