Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: use cookie or localStorage for further pages on the same domain. #22

Closed
FrankConijn opened this issue May 23, 2018 · 6 comments
Assignees

Comments

@FrankConijn
Copy link

FrankConijn commented May 23, 2018

By doing that, it is avoided that the Does-this-browser-support-the-needed-CSS-hyphenation? test script runs on every page of that particular website. Which, if I'm not mistaking, takes considerably more time than a cookie retrieval script.

@FrankConijn FrankConijn changed the title Suggestion: use cookie or web storage for further pages on same domain. Suggestion: use cookie or localStorage for further pages on the same domain. May 23, 2018
@mnater
Copy link
Owner

mnater commented May 23, 2018

Good point

@mnater mnater self-assigned this May 23, 2018
@mnater mnater added this to the 2.0.0 milestone May 23, 2018
@mnater
Copy link
Owner

mnater commented May 24, 2018

Added with commit b101ac0

Todo:

  • add documentation

@mnater
Copy link
Owner

mnater commented May 27, 2018

@mnater mnater closed this as completed May 27, 2018
@FrankConijn
Copy link
Author

Cool, but for the sake of user-friendliness — beginner web designers will want to use your system, too — I would activate the cacheFeatureTests default. The cookie regulations do not concern cookies that only serve the user experience. And people really don't have any objections against those cookies. At least you should make clear where that Javascript line is to be found & altered, or pasted.

@FrankConijn
Copy link
Author

Maybe you missed the last sentence of my last post, but I don't know where to change or paste this:

const Hyphenopoly = {
require: {...},
cacheFeatureTests: true
}

I cannot find it in either Hyphenopoly.js or Hyphenolpoly_Loader.js.

@mnater
Copy link
Owner

mnater commented Jun 2, 2018

No, I didn't miss it. I just hadn't time to reply.

About activating the storage by default:
I'm not a lawyer and it's not only about the regulations in the EU. It's just safer if it's not activated.

Where to activate:
You don't need to change a line of code in Hyphenopoly.js nor Hyphenolpoly_Loader.js.
Hyphenopoly is the global object where you config how the scripts behave. See: https://github.com/mnater/Hyphenopoly/wiki/Global-Hyphenopoly-Object.
I updated the doc accordingly.

@mnater mnater reopened this Dec 2, 2018
@mnater mnater closed this as completed Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants