No SSP by default; remove "use_{ica,ssp}" settings in favor of new setting "spatial_filter" #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
changed the title
hoechenberger
commented
Apr 29, 2021
agramfort
reviewed
Apr 29, 2021
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
|
Thanks! I was going to suggest to make it optional too and have either: ssp, ica or none. Since if you mark both as true it gives you error, so it's more convenient from people to be prevented with this optional choice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/changes.md)@guiomar @agramfort WDYT?
x-ref: #314