bug in the sanity check after maxfilters. #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @crsegerie! I've just merged #335, which should solve the early CI errors we're seeing here. Can you pull |
agramfort
approved these changes
May 21, 2021
There was a problem hiding this comment.
@hoechenberger merge if you think it will break CI effectively
😅 |
|
Thanks, @crsegerie! |
|
👍 @crsegerie 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sanity check comparing the rank of the experimental data and the rank of the empty-room after the maxfilter did not use the maxfiltered matrices
Before merging …
docs/source/changes.md)