configuration: conditions parameter set to None
#348
Conversation
|
Hi! I tried to set the |
There was a problem hiding this comment.
Thanks @guiomar! Let's see what CI says, but it's looking good to me so far. Can you please add a changelog entry too?
|
@guiomar if you navigate to "Files changed" (https://github.com/mne-tools/mne-bids-pipeline/pull/348/files) you can then add the review suggestions to a batch and create a commit directly here on GitHub to apply these changes |
|
Thanks! I'll try! I also made a new entry in the changes.md. Can you see it? |
|
Shall I have to click "add suggestions to batch" or "commit suggestion" for each of your changes? |
"commit suggestion" creates one commit per suggestion. This can be annoying if you wish to apply multiple suggestions in one go. Then, it's quicker (and cleaner) to "Add suggestion to batch" until the batch contains all suggestions you wish to apply, and then you click on the commit button that will appear. This will create a single commit with all selected suggestions |
Yes! :) Already commented |
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
|
@guiomar can you have a look at the CI failure? thx |
|
@agramfort We looked at this briefly yesterday, the last commit needs to be reverted |
|
Yes! Sorry, I wanted to do another PR and mixed with this |
|
Our CI system had some issues which I managed to fix! All good now |
|
Thanks, @guiomar! 🚀 |
Before merging …
docs/source/changes.md)