Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exclude_runs #370

Merged
merged 9 commits into from
Jun 7, 2021
Merged

add exclude_runs #370

merged 9 commits into from
Jun 7, 2021

Conversation

crsegerie
Copy link
Contributor

Closes #366

Before merging …

  • Changelog has been updated (docs/source/changes.md)

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, I left a few comments!

config.py Outdated Show resolved Hide resolved
config.py Show resolved Hide resolved
config.py Outdated Show resolved Hide resolved
docs/source/changes.md Show resolved Hide resolved
docs/source/changes.md Outdated Show resolved Hide resolved
crsegerie and others added 3 commits June 7, 2021 11:26
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config.py Show resolved Hide resolved
config.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@crsegerie crsegerie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

individually

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh we forgot to add the new param to the docs. @crsegerie Can you have a look how we do this with the other params? Search for: ::: config.

config.py Outdated Show resolved Hide resolved
Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait for the doc build to come back before merging

@hoechenberger
Copy link
Member

@hoechenberger hoechenberger merged commit c6dbf13 into mne-tools:main Jun 7, 2021
@hoechenberger
Copy link
Member

Thanks @crsegerie!!

@crsegerie crsegerie deleted the exclude_runs branch June 7, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a param exclude_runs?
3 participants