Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add automated break annotation #386

Merged
merged 4 commits into from
Jun 18, 2021
Merged

ENH: Add automated break annotation #386

merged 4 commits into from
Jun 18, 2021

Conversation

hoechenberger
Copy link
Member

Before merging …

  • Changelog has been updated (docs/source/changes.md)

hoechenberger
hoechenberger commented Jun 17, 2021
View reviewed changes
config.py Outdated Show resolved Hide resolved
hoechenberger
hoechenberger commented Jun 17, 2021
View reviewed changes
config.py Outdated Show resolved Hide resolved
hoechenberger
hoechenberger commented Jun 17, 2021
View reviewed changes
config.py Outdated Show resolved Hide resolved
hoechenberger
hoechenberger commented Jun 17, 2021
View reviewed changes
config.py Outdated Show resolved Hide resolved
hoechenberger
hoechenberger commented Jun 17, 2021
View reviewed changes
config.py Outdated Show resolved Hide resolved
@hoechenberger
Copy link
Member Author

@agramfort Any ideas for shorter parameter names? 🤔

agramfort
agramfort approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@hoechenberger
Copy link
Member Author

@agramfort Style check fails because lines are getting too long due to t_break_annot_start_after_previous_event and t_break_annot_stop_before_next_event. But honestly I cannot think of anything more concise that would still be descriptive.

@agramfort
Copy link
Member

agramfort commented Jun 17, 2021 via email

@hoechenberger hoechenberger merged commit 88ca040 into mne-tools:main Jun 18, 2021
@hoechenberger hoechenberger deleted the annotate-breaks branch June 18, 2021 08:01
@hoechenberger hoechenberger mentioned this pull request Jun 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoechenberger @agramfort