Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for EEG processing of ds117 #416

Merged
merged 4 commits into from
Jul 9, 2021
Merged

fixes for EEG processing of ds117 #416

merged 4 commits into from
Jul 9, 2021

Conversation

agramfort
Copy link
Member

@agramfort agramfort commented Jul 9, 2021 •
edited by hoechenberger

Before merging …

  • Changelog has been updated (docs/source/changes.md)

hoechenberger
hoechenberger approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you add a tiny changelog entry?

hoechenberger
hoechenberger approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM once CI is green

docs/source/changes.md Outdated Show resolved Hide resolved
@hoechenberger
Copy link
Member

Will rebase after #413 has been merged

@hoechenberger hoechenberger merged commit ef02c6e into mne-tools:main Jul 9, 2021
@hoechenberger
Copy link
Member

Thanks @agramfort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoechenberger hoechenberger hoechenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agramfort @hoechenberger