Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storing processing logs and failures in excel file #429

Merged
merged 32 commits into from
Jul 15, 2021
Merged

Storing processing logs and failures in excel file #429

merged 32 commits into from
Jul 15, 2021

Conversation

agramfort
Copy link
Member

@hoechenberger I would love your input on this one

@agramfort agramfort changed the title WIP : first draft so you get the idea WIP : Storing processing logs and failures in excel file Jul 13, 2021
@hoechenberger
Copy link
Member

@agramfort
Seems the JSON dump fails if mri_t1_path_generator is set (function cannot be converted to JSON). I would say that the solution to that is to replace the value of mri_t1_path_generator with a string such as <func: function_name> before converting to JSON. WDYT?

@hoechenberger
Copy link
Member

(Alternatively, we could dump the entire function content … But that might be too much?)

hoechenberger
hoechenberger reviewed Jul 13, 2021
View reviewed changes
config.py Outdated Show resolved Hide resolved
hoechenberger
hoechenberger reviewed Jul 14, 2021
View reviewed changes
config.py Outdated Show resolved Hide resolved
config.py Show resolved Hide resolved
config.py Outdated Show resolved Hide resolved
hoechenberger
hoechenberger reviewed Jul 14, 2021
View reviewed changes
config.py Outdated Show resolved Hide resolved
hoechenberger
hoechenberger reviewed Jul 14, 2021
View reviewed changes
config.py Outdated Show resolved Hide resolved
@agramfort agramfort merged commit 4751976 into mne-tools:main Jul 15, 2021
@agramfort
Copy link
Member Author

just tested with @apmellot and it works like a charm !

@hoechenberger
Copy link
Member

amazing!!!!!! 🥳 🍾

@hoechenberger hoechenberger changed the title WIP : Storing processing logs and failures in excel file Storing processing logs and failures in excel file Jul 15, 2021
@apmellot
Copy link
Contributor

Thank you very much @hoechenberger and @agramfort, this will change my life ! 😄

@larsoner
Copy link
Member

Looks like this PR broke builds on main, see failures in #435 and #433

@larsoner larsoner mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoechenberger hoechenberger hoechenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@agramfort @hoechenberger @apmellot @larsoner