Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epochs to the report. Add plot_psd_for_runs setting. #482

Merged
merged 3 commits into from
Dec 2, 2021

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Dec 1, 2021

Previously we'd only plot the PSD of raw data for the first run to speed up report generation. Working with @SophieHerbst we discovered that this is not a good choice for us, so this PR:

  • changes the default behavior such that we get a PSD plot for each run
  • add a new config option, plot_psd_for_runs, allowing users to control this behavior

Also, we now add epochs to the report. It appears I simply forgot about them when transitioning to the new MNE Report API.

Before merging …

  • Changelog has been updated (docs/source/changes.md)

docs/source/changes.md Outdated Show resolved Hide resolved
@hoechenberger hoechenberger changed the title Add plot_psd_for_runs setting Add epochs to the report. Add plot_psd_for_runs setting. Dec 1, 2021
@hoechenberger
Copy link
Member Author

@hoechenberger hoechenberger marked this pull request as ready for review December 1, 2021 17:44
@hoechenberger hoechenberger merged commit 2d53f1b into mne-tools:main Dec 2, 2021
@hoechenberger hoechenberger deleted the plot-psd-runs branch December 2, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants