Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stronger decimation for MRI & BEM plotting #488

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Stronger decimation for MRI & BEM plotting #488

merged 2 commits into from
Dec 14, 2021

Conversation

hoechenberger
Copy link
Member

Tested source report rendering with some real-world data.

MRI/BEM rendering was sped up by ~80%
Souce-space report became 20% smaller
(still way too big though, but we're slowly getting there!)

main:
report size: 114 MB
BEM rendering duration: 49 sec

PR:
report size: 91 MB 
BEM rendering duration: 10 sec

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@hoechenberger hoechenberger marked this pull request as ready for review December 14, 2021 16:05
@hoechenberger hoechenberger merged commit cdcf37d into mne-tools:main Dec 14, 2021
@hoechenberger hoechenberger deleted the bem-decimation branch December 14, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoechenberger @agramfort