Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rank deficiency when working with multi-run Maxwell-filtered data #530

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Apr 11, 2022

Before merging …

  • Changelog has been updated (docs/source/changes.md)

cc @agramfort

@hoechenberger
Copy link
Member Author

@agramfort This is ready to be merged, seems to work without problems with our real-world data!

@hoechenberger
Copy link
Member Author

Let's discuss tomorrow how we can bring this upstream to MNE-Python!

But for now I'd like to get this merged here; happy to revert again later once upstream is fixed.

@agramfort agramfort merged commit 3d2a214 into mne-tools:main Apr 12, 2022
@agramfort
Copy link
Member

thx @hoechenberger

@hoechenberger hoechenberger deleted the mf-rank branch April 12, 2022 09:42
@hoechenberger hoechenberger restored the mf-rank branch April 12, 2022 18:43
@agramfort
Copy link
Member

@mathias-sm here are PRs related to the rank issue mentioned this afternoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants