ENH: Add ssp_meg option #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
agramfort
reviewed
Sep 4, 2022
|
ok so should be make it "auto" and default to "combined" if maxfilter is on?
… Message ID: ***@***.***
.com>
|
|
Ideally I think we would do this in MNE-Python first, but I guess we can add it here instead |
|
(the backward compat break there would be a pain) |
hoechenberger
approved these changes
Sep 4, 2022
|
Thanks @larsoner! CI should pass. |
agramfort
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/changes.md)When using maxfiltered data,
meg='combined'usually makes sense. Maybe we should have this default toTruemeaning "combined when using maxfilter and separate otherwise", but this should maybe be an upstream change first in MNE-Python. In the meantime, let's expose the option at least.