-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix URL #600
BUG: Fix URL #600
Conversation
I'll probably take care of #539 here as well since it should be easy enough hopefully |
I just glanced at the errant filename for mne-tools/mne-bids-pipeline#600, it only became glaringly obvious what the error was once I offered some suggestions: ``` RuntimeError: Could not find path in the dataset: - sub-001/eeg/sub-001_task-AudioCueWalkingStudy_run-01_events.tsvsub-001/eeg/sub-001_task-AudioCueWalkingStudy_run-01_eeg.set Perhaps you mean one of these paths: - sub-001/eeg/sub-001_task-AudioCueWalkingStudy_run-01_events.tsv - sub-001/eeg/sub-001_task-AudioCueWalkingStudy_run-14_events.tsv - sub-001/eeg/sub-001_task-AudioCueWalkingStudy_run-13_events.tsv Please check your includes. ``` This PR makes these suggestions. Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Personally I prefer this dryer option. +1 merge after the CIs are green. Note that the new dataset shall be added to the documentation page too. |
I think there is a bug with 1971 with
It has two EDIT: Looks like those subject ids are not even in the original file: https://openneuro.org/datasets/ds001971/versions/1.1.1/file-display/participants.tsv / mne-tools/mne-bids#1065 |
Before merging …
docs/source/changes.md
)Okay the basic fix was easy.
Draft because I'm not sure how this download has ever worked, as this error appears in theblame
from 2 years ago when it was added. It appears not to be used on CircleCI -- should it be? If so, I'll add another little sanity check test here that any dataset indatasets.py
has at least some matching code in.circleci/config.yml
.Closes #599
Closes #539