-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add M/EEG processing #606
Conversation
Not quite ready yet, some plots missing from the report |
* upstream/main: Set on_missing parameter of raw.drop_channels to warn by default. (mne-tools#610) ENH: More caching and fixes (mne-tools#608)
Ready for review/merge from my end. Actually what I thought was missing was actually correct -- the empty-room plots should only have MEG channels. All other plots seem to reasonably contain MEG+EEG. Also fixes a bug where STIM channels were included in decoding (whoops!). Now when we |
Okay there was still a bug with picking. I changed the default I also fixed a doc bug where the "used in this example" was not determined properly because things like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🙏
Before merging …
docs/source/changes.md
)AddCheck that conditional that empty-room cov cannot be used for MEG+EEG data EDIT: Already exists@hoechenberger @agramfort sound like a plan? Also, why was SSP for EEG not supported / explicitly an error before? Looks like the error conditional that I removed here was added in #92 or so.
Closes #601