ENH: Show progress for fitting #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Thanks @larsoner |
larsoner
added a commit
to larsoner/mne-bids-pipeline
that referenced
this pull request
Nov 9, 2022
* upstream/main: MAINT: Simplify by removing fire (mne-tools#649) ENH: Show progress for fitting (mne-tools#647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/changes.md)Closes #570
Unfortunately we can't really get this to work for
dask-- workers can't write to the host to give updates, and thememmapapproach that works for joblib does not appear to work for dask -- so there no progress bar is shown. The alternative would be to show a progress bar that doesn't update at all, which seems worse than not showing one in the first place.Locally if I comment out the
parallel_backend = 'dask'and use the bugfix branch mne-tools/mne-python#11311, then I get nice updates:Peek.2022-11-09.08-40.mp4