BUG: Fix bug with sys info addition #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| [//]: # (- Whatever (#000 by @whoever)) | ||
| - Fix pandas 2.0 compatibility (#732 by @larsoner) |
There was a problem hiding this comment.
I'd add this to the code health section instead as
- Support report generation with pandas 2.0 (#732 by @larsoner)
WDYT? Since it's not a bug
There was a problem hiding this comment.
To me it was a bug that we were knowingly using a deprecated API, and users will see it as an error (no pipeline can even run with latest pandas). So to me it's above the level of "code health" which sounds like stuff maintainers should mostly care about
|
Thanks @larsoner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/changes.md)Closes #728